Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Apr 27, 2023

DO NOT MERGE BEFORE 30-APR

According to our policy https://github.com/apache/airflow/blob/main/PROVIDERS.rst#minimum-supported-version-of-airflow-for-community-managed-providers

Note for reviewers:
Providers that are pre-installed with Airflow (Sqlite, common.sql etc..) do not have minimum Airflow version thus left out of this PR.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this provider didn't have minimum Airflow version at all

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@potiuk potiuk added the allow suspended provider changes Allow changes in suspended providers label Apr 27, 2023
@potiuk potiuk closed this Apr 27, 2023
@potiuk potiuk reopened this Apr 27, 2023
@potiuk
Copy link
Member

potiuk commented Apr 27, 2023

Rebased, applied label, closed/reopened to test it @eladkal

@potiuk
Copy link
Member

potiuk commented Apr 27, 2023

You will also need to bump 2.4 in the "compatibility job".

@eladkal
Copy link
Contributor Author

eladkal commented Apr 28, 2023

all green

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit a7eb32a into apache:main Apr 29, 2023
@eladkal eladkal deleted the providers branch April 30, 2023 17:22
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

allow suspended provider changes Allow changes in suspended providers area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:celery provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:databricks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants