Refactor GCS list hook to support multiple prefixes #30815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
reviewed
Apr 22, 2023
Comment on lines
740
to
755
Contributor
There was a problem hiding this comment.
Do we need a new function for it?
Can't we add List[str] support for prefix parameter in list() function?
Contributor
Author
There was a problem hiding this comment.
Good catch, it indeed makes more sense to encapsulate the existing list method within an inner function and convert the list_by_prefix into the list method. Working on it.
e78043e to
3873ce4
Compare
3873ce4 to
52abaa0
Compare
potiuk
approved these changes
Apr 22, 2023
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10426
This PR refactors GCS hook's method
list()to support multiple prefixes passed as a list of strings.It also updates
GCSDeleteBucketOperatorandGCSListObjectsOperatoroperators to utilize the updated hook.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.