Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 12, 2023

Additional chek on cloud sql version should be done to avoid downloading non-existing binary.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Feb 12, 2023
@potiuk potiuk force-pushed the verify-cloud-sql-proxy-parameter branch from c599c27 to d723002 Compare February 12, 2023 23:09
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just a few nits

Additional chek on cloud sql version should be done to avoid
downloading non-existing binary.
@potiuk potiuk force-pushed the verify-cloud-sql-proxy-parameter branch from addf2e4 to 97ce408 Compare February 13, 2023 10:19
@potiuk potiuk merged commit 5e6f8eb into apache:main Feb 13, 2023
@potiuk potiuk deleted the verify-cloud-sql-proxy-parameter branch February 13, 2023 14:31
@potiuk
Copy link
Member Author

potiuk commented Feb 13, 2023

Lgtm, just a few nits

Applied. Tests passed. merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants