Add a new param for BigQuery operators to support additional actions when resource exists #29394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d depracte old one
2 tasks
Taragolis
reviewed
Feb 18, 2023
Comment on lines
1266
to
1269
| :param exists_ok: Deprecated - use `if_exists="ignore"` instead. | ||
| :param if_exists: What should Airflow do if the table exists. If set to `log`, the TI will be passed to | ||
| success and an error message will be logged. Set to `ignore` to ignore the error, set to `fail` to | ||
| fail the TI, and set to `skip` to skip it. |
Contributor
There was a problem hiding this comment.
Small nit, I think it is a good idea move deprecated parameters into the bottom of arguments lists and because operator only supports keyword arguments, this is not break any pipeline.
Member
Author
There was a problem hiding this comment.
It's a good idea, I did it for all deprecated parameters in the file and not just in the operators I changed.
Taragolis
approved these changes
Feb 19, 2023
Contributor
|
cc: @mfjackson if you have a time could you also have a look. Is it what you expected for solve #29301 ? |
eladkal
approved these changes
Feb 26, 2023
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #29301
Add a new parameter for
BigQueryCreateEmptyTableOperatorandBigQueryCreateEmptyDatasetOperatorto support additional actions when the table or the dataset exists.