Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Dec 29, 2021

Part of #19891


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Dec 29, 2021

Looks like the global Context replace worked flawlessly :) . All tests are geting green :)

@potiuk potiuk requested a review from jedcunningham December 29, 2021 23:00
@potiuk
Copy link
Member Author

potiuk commented Dec 29, 2021

Just 214 files :)

@potiuk
Copy link
Member Author

potiuk commented Dec 29, 2021

It's - surprisingly - indeed green :)

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through all the diffs (phew).

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 29, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit a082123 into apache:main Dec 29, 2021
@potiuk potiuk deleted the add-context-typing-everywhere branch December 29, 2021 23:21
@potiuk potiuk restored the add-context-typing-everywhere branch January 11, 2022 18:44
@ephraimbuddy ephraimbuddy added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Apr 14, 2022
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 14, 2022
@potiuk potiuk deleted the add-context-typing-everywhere branch July 29, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants