[Part 1]: Add hook for integrating with Google Calendar #20542
Conversation
turbaszek
left a comment
There was a problem hiding this comment.
Apart few small comment it looks good!
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
@rsg17 can you please take a look at failing docs and static checks builds? |
7376473 to
d1e88e4
Compare
Done. All checks passed now! |
|
Based on #11419 being brought up recently, should this be all be packaged under |
Not for now since no one is working on this. |
a05442a to
7d936a4
Compare
eladkal
left a comment
There was a problem hiding this comment.
Overall LGTM
left minor comments
turbaszek
left a comment
There was a problem hiding this comment.
Minor comment but otherwise looks good to me!
|
Great job @rsg17 ! Now it's time to add some operators 🚀 |
Thank you for your suggestions and reviews @turbaszek and @eladkal. Will work on operators next. Happy new year!! |
related: #8471
This PR adds hook for integrating with Google Calendar and corresponding unit tests. The code/steps follow a structure similar to that of Google Sheets integration.
Further steps to close #8471 involve creating operators to write to GCS, corresponding unit tests and system tests. I will create those as a separate PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.