Fixed wrongly escaped characters in amazon's changelog #17020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Unfortunately escaped characters broke packages - found it out via twine check. Documentation regenerated. |
eladkal
approved these changes
Jul 15, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
In case we have additional dependencies between providers released at the same time (for example we need to release sftp and ssh packages now where sftp package depends on release of ssh at the same time) we have to add suffix to the version of the additional_dependency. PIP does not take into account unfortunately that development dependencies should likely be considered as fulfilling the requirement of >=. For example if you have: sftp depends on ssh>=2.1.0 and you release ssh 2.1.0.dev0 at the same time the ssh>=2.1.0 condition is not fulfilled. Same case will be with rc1. Therefore we need to add the suffix in such cross-provider dependencies to be able to install them in CI and in rc candidates. In the future we might ask PIP to change behaviour in such case.
* fixed a problem with documentation generation problem with html-escaped characters * regenerated the documentation to include the changelog changes.
21b146f to
1b7865a
Compare
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also regenerated the documentation to include the changelog changes
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.