Add exists_ok flag to BigQueryCreateEmptyTable(Dataset)Operator
#14026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exists_ok flagexists_ok flag to BigQueryCreateEmptyTable(Dataset)Operator
ephraimbuddy
requested changes
Feb 6, 2021
Contributor
ephraimbuddy
left a comment
There was a problem hiding this comment.
Just nitpicking here, LGTM
| Service Account Token Creator IAM role to the directly preceding identity, with first | ||
| account from the list granting this role to the originating account (templated). | ||
| :type impersonation_chain: Union[str, Sequence[str]] | ||
| :param exists_ok: If ``True``, ignore "already exists" errors when creating the DATASET. |
Contributor
There was a problem hiding this comment.
Suggested change
| :param exists_ok: If ``True``, ignore "already exists" errors when creating the DATASET. | |
| :param exists_ok: If ``True``, ignore "already exists" errors when creating the dataset. |
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
ephraimbuddy
approved these changes
Feb 6, 2021
turbaszek
approved these changes
Feb 13, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
exists_okflag toBigQueryCreateEmptyTableOperatorandBigQueryCreateEmptyDatasetOperator.It makes it possible to ignore "already exists" errors.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.