Skip to content

Conversation

@griffincosgrove
Copy link
Contributor

Added missing logos .png images and updated provider.yaml file to point to the path for the logo image. Currently, there are many logos on the Apache Site that do not have logo images. Closes #13110

@boring-cyborg boring-cyborg bot added provider:Apache provider:microsoft-azure Azure-related issues provider:google Google (including GCP) related issues labels Jan 16, 2021
@griffincosgrove
Copy link
Contributor Author

@mik-laj think please help me with the review... again 😄

@mik-laj
Copy link
Member

mik-laj commented Jan 18, 2021

One integration still has a checkerboard pattern.
Screenshot 2021-01-18 at 13 29 40

Can you also add a logo for singularity?
https://sylabs.io/guides/3.7/user-guide/_static/logo.png

@griffincosgrove
Copy link
Contributor Author

yes @mik-laj, I will do that right now 😄 sorry about that.

@griffincosgrove
Copy link
Contributor Author

@mik-laj please check again 😃

@mik-laj
Copy link
Member

mik-laj commented Jan 19, 2021

One more chessboard left, but this time it was slightly less visible.
Screenshot 2021-01-19 at 17 17 01

@griffincosgrove
Copy link
Contributor Author

@mik-laj replaced the azure file share logo.

@mik-laj
Copy link
Member

mik-laj commented Jan 21, 2021

Perfect!
Screenshot 2021-01-21 at 01 20 47

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 21, 2021
@mik-laj mik-laj merged commit 3fd5ef3 into apache:master Jan 21, 2021
@griffincosgrove
Copy link
Contributor Author

Thanks for helping with the review! 😀 @mik-laj

@potiuk
Copy link
Member

potiuk commented Jan 21, 2021

Cool. I might even try to incorporate that into the Provider Readme's :)

@griffincosgrove
Copy link
Contributor Author

Let me know if I can help @potiuk

thanks for the help lads! Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing logos for integrations

3 participants