Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Sep 8, 2020

We got clarification in psf/black#1667 that the new changes related to trailing commas are feature instead of a bug. Previously our suspicion was that pyproject.toml wasn't respected as we thought the changes were because of line length

On closer inspection it is more clearer and better than previous version.

Old:

    return variable_collection_schema.dump({"variables": variables, "total_entries": total_entries,})

New:

return variable_collection_schema.dump(
        {
            "variables": variables,
            "total_entries": total_entries,
        }
    )

The trailing comma looks better on the new line .

Old:

        "containerOverrides": [{"name": "hello-world-container", "command": ["echo", "hello", "world"],},],

New:

        "containerOverrides": [
            {
                "name": "hello-world-container",
                "command": ["echo", "hello", "world"],
            },
        ],

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:dev-tools area:secrets provider:Apache provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues labels Sep 8, 2020
@kaxil kaxil requested a review from potiuk September 8, 2020 23:08
@kaxil kaxil removed area:API Airflow's REST/HTTP API area:secrets area:dev-tools provider:amazon AWS/Amazon - related issues provider:Apache provider:google Google (including GCP) related issues labels Sep 8, 2020
@kaxil kaxil requested a review from feluelle September 9, 2020 07:43
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I did not check all changes - I hope Kaxil all the changes were done automatically by black :)).

@kaxil kaxil merged commit 9549274 into apache:master Sep 9, 2020
@kaxil kaxil deleted the upgrade-black branch September 9, 2020 08:06
@kaxil
Copy link
Member Author

kaxil commented Sep 9, 2020

LGTM (I did not check all changes - I hope Kaxil all the changes were done automatically by black :)).

Yup

@potiuk
Copy link
Member

potiuk commented Sep 9, 2020

LGTM (I did not check all changes - I hope Kaxil all the changes were done automatically by black :)).

Nooooo.. How could you :) ! only 5000 lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants