Skip to content

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Jul 26, 2020


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@22quinn
Copy link
Contributor

22quinn commented Jul 27, 2020

Nice consolidation! I was also thinking about the same thing.

On the naming, what do you think about just SQLOperator?
We have BranchPythonOperator -> PythonOperator (We did not call it PythonRunCodeOperator), so BranchSQLOperator -> SQLOperator

# specific language governing permissions and limitations
# under the License.
"""This module is deprecated. Please use `airflow.providers.vertica.operators.vertica`."""
"""This module is deprecated. Please use `airflow.providers.sqlite.operators.sqlite`."""
Copy link
Member

@turbaszek turbaszek Jul 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sqlite?

Suggested change
"""This module is deprecated. Please use `airflow.providers.sqlite.operators.sqlite`."""
"""This module is deprecated. Please use `airflow.providers.sql.operators.sql`."""

conn_id='sqlite_default',
dag=self.dag,
)
op.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this create side effect on db level? Should we clear database after tests?

@mik-laj
Copy link
Member Author

mik-laj commented Jul 27, 2020

On the naming, what do you think about just SQLOperator?

Now we are trying to give more ambiguous names to make it easier to add new operators and to understand the operator's behavior without reading its description.
A good example is BigQueryOperator, which could do multiple operations, but In Airflow 2.0, we've given it the more precisive name BigQueryExecuteQuery. This allows this operator to be easily distinguished from other operators that perform other operations.
More info:
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#naming-conventions-for-provider-packages

@stale
Copy link

stale bot commented Sep 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 11, 2020
@stale stale bot closed this Sep 20, 2020
@mik-laj mik-laj reopened this Sep 20, 2020
@stale stale bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 20, 2020
@mik-laj mik-laj added the pinned Protect from Stalebot auto closing label Sep 20, 2020
@mik-laj mik-laj added this to the Airflow 2.0.0 milestone Sep 20, 2020
@potiuk
Copy link
Member

potiuk commented Dec 7, 2020

Hey @mik-laj -> is it something we will managed add before 2.0.0rc1? If not, can you please change the milestone?

@kaxil kaxil modified the milestones: Airflow 2.0.0rc1, Airflow 2.1 Dec 7, 2020
@mik-laj
Copy link
Member Author

mik-laj commented Dec 8, 2020

It is unlikely that I will find time for this.

@ashb ashb modified the milestones: Airflow 2.1, Airflow 2.1.1 May 18, 2021
@kaxil kaxil modified the milestones: Airflow 2.1.1, Airflow 2.2 Jun 22, 2021
@eladkal eladkal mentioned this pull request Jul 24, 2022
1 task
@eladkal
Copy link
Contributor

eladkal commented Aug 25, 2022

closed in favor of #25717

@eladkal eladkal closed this Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pinned Protect from Stalebot auto closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants