Enable test connection in UI if explicitly set to Enabled (#33342)

pankajkoti · web-flow · commit 50765eb08836 · 2023-08-12T15:27:36.000+02:00
Following up PR #32052 the test connection is disabled in UI, API and CLI. The API and CLI strictly check for the config value to be set as `Enabled` for the functionality to be enabled, whereas the UI just checks that is it not set to `Disabled`. As a result setting values to the config param other than `Disabled`, enables the button in the UI. Even though the button gets enabled, the API forbids it as there is a strict check in the API that the value is set to `Enabled` and only then allows, however, it makes sense to also strictly check in the UI that value is set to `Enabled`.
diff --git a/airflow/www/static/js/connection_form.js b/airflow/www/static/js/connection_form.js
@@ -135,7 +135,7 @@ function handleTestConnection(connectionType, testableConnections) {
     $(testButton).hide();
     return;
   }
-  if (configTestConnection === "disabled") {
+  if (configTestConnection !== "enabled") {
     // If test connection is not enabled in config, disable button and display toolip
     // alerting the user.
     $(testButton)

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ function handleTestConnection(connectionType, testableConnections) {`
`135`	`135`	`$(testButton).hide();`
`136`	`136`	`return;`
`137`	`137`	`}`
`138`		`- if (configTestConnection === "disabled") {`
	`138`	`+ if (configTestConnection !== "enabled") {`
`139`	`139`	`// If test connection is not enabled in config, disable button and display toolip`
`140`	`140`	`// alerting the user.`
`141`	`141`	`$(testButton)`