Skip to content

Fix connect wallet menu in react example app#1364

Merged
mcintyre94 merged 1 commit intomainfrom
menu-fix
Feb 13, 2026
Merged

Fix connect wallet menu in react example app#1364
mcintyre94 merged 1 commit intomainfrom
menu-fix

Conversation

@mcintyre94
Copy link
Copy Markdown
Member

@mcintyre94 mcintyre94 commented Feb 12, 2026

Problem

Spotted an issue in the react-app example

Screenshot 2026-02-12 at 17 27 17

The SubTrigger element in ConnectWalletMenuItem.tsx was using DropdownMenuPrimitive. I think a newer version of radix-themes (which dependabot bumped) added support for DropdownMenu.SubTrigger, but also throws an error now if you mix the primitive with the menu.

Summary of Changes

  • Just use DropdownMenu.SubTrigger
  • Remove the classes, because the ones we had were just replicating radix-themes before it had SubTrigger
Screenshot 2026-02-12 at 17 25 46

Fixes broken react app example

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 12, 2026

⚠️ No Changeset found

Latest commit: a2970b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bundlemon
Copy link
Copy Markdown

bundlemon Bot commented Feb 12, 2026

BundleMon

Unchanged files (139)
Status Path Size Limits
✅ @solana/kit production bundle
kit/dist/index.production.min.js
 41.21KB -
✅ rpc-graphql/dist/index.browser.mjs
 18.82KB -
✅ rpc-graphql/dist/index.native.mjs
 18.81KB -
✅ rpc-graphql/dist/index.node.mjs
 18.81KB -
✅ errors/dist/index.node.mjs
 17.94KB -
✅ errors/dist/index.browser.mjs
 17.92KB -
✅ errors/dist/index.native.mjs
 17.91KB -
✅ transaction-messages/dist/index.browser.mjs
 7.29KB -
✅ transaction-messages/dist/index.native.mjs
 7.29KB -
✅ transaction-messages/dist/index.node.mjs
 7.29KB -
✅ instruction-plans/dist/index.browser.mjs
 5.54KB -
✅ instruction-plans/dist/index.native.mjs
 5.54KB -
✅ instruction-plans/dist/index.node.mjs
 5.54KB -
✅ offchain-messages/dist/index.browser.mjs
 4.89KB -
✅ offchain-messages/dist/index.native.mjs
 4.89KB -
✅ offchain-messages/dist/index.node.mjs
 4.89KB -
✅ codecs-data-structures/dist/index.browser.mjs
 4.69KB -
✅ codecs-data-structures/dist/index.native.mjs
 4.69KB -
✅ codecs-data-structures/dist/index.node.mjs
 4.69KB -
✅ codecs-core/dist/index.browser.mjs
 3.61KB -
✅ codecs-core/dist/index.native.mjs
 3.61KB -
✅ codecs-core/dist/index.node.mjs
 3.61KB -
✅ webcrypto-ed25519-polyfill/dist/index.node.mj
s
 3.61KB -
✅ webcrypto-ed25519-polyfill/dist/index.browser
.mjs
 3.59KB -
✅ webcrypto-ed25519-polyfill/dist/index.native.
mjs
 3.57KB -
✅ rpc-subscriptions/dist/index.browser.mjs
 3.37KB -
✅ rpc-subscriptions/dist/index.node.mjs
 3.34KB -
✅ rpc-subscriptions/dist/index.native.mjs
 3.31KB -
✅ rpc-transformers/dist/index.browser.mjs
 3.16KB -
✅ rpc-transformers/dist/index.native.mjs
 3.16KB -
✅ rpc-transformers/dist/index.node.mjs
 3.16KB -
✅ react/dist/index.browser.mjs
 3.09KB -
✅ react/dist/index.native.mjs
 3.09KB -
✅ react/dist/index.node.mjs
 3.09KB -
✅ addresses/dist/index.browser.mjs
 2.93KB -
✅ addresses/dist/index.native.mjs
 2.92KB -
✅ addresses/dist/index.node.mjs
 2.92KB -
✅ signers/dist/index.browser.mjs
 2.9KB -
✅ signers/dist/index.native.mjs
 2.9KB -
✅ signers/dist/index.node.mjs
 2.9KB -
✅ transactions/dist/index.browser.mjs
 2.87KB -
✅ transactions/dist/index.native.mjs
 2.86KB -
✅ transactions/dist/index.node.mjs
 2.86KB -
✅ codecs-strings/dist/index.browser.mjs
 2.53KB -
✅ codecs-strings/dist/index.node.mjs
 2.49KB -
✅ codecs-strings/dist/index.native.mjs
 2.45KB -
✅ transaction-confirmation/dist/index.node.mjs
 2.41KB -
✅ transaction-confirmation/dist/index.native.mj
s
 2.36KB -
✅ transaction-confirmation/dist/index.browser.m
js
 2.35KB -
✅ sysvars/dist/index.browser.mjs
 2.35KB -
✅ sysvars/dist/index.native.mjs
 2.34KB -
✅ sysvars/dist/index.node.mjs
 2.34KB -
✅ kit/dist/index.browser.mjs
 2.22KB -
✅ kit/dist/index.native.mjs
 2.22KB -
✅ kit/dist/index.node.mjs
 2.22KB -
✅ rpc-subscriptions-spec/dist/index.node.mjs
 2.18KB -
✅ rpc-subscriptions-spec/dist/index.native.mjs
 2.13KB -
✅ rpc-subscriptions-spec/dist/index.browser.mjs
 2.13KB -
✅ keys/dist/index.browser.mjs
 2.1KB -
✅ keys/dist/index.native.mjs
 2.1KB -
✅ keys/dist/index.node.mjs
 2.1KB -
✅ rpc/dist/index.node.mjs
 1.95KB -
✅ codecs-numbers/dist/index.browser.mjs
 1.95KB -
✅ codecs-numbers/dist/index.native.mjs
 1.95KB -
✅ codecs-numbers/dist/index.node.mjs
 1.94KB -
✅ rpc-transport-http/dist/index.browser.mjs
 1.91KB -
✅ rpc-transport-http/dist/index.native.mjs
 1.9KB -
✅ rpc/dist/index.native.mjs
 1.81KB -
✅ rpc/dist/index.browser.mjs
 1.8KB -
✅ subscribable/dist/index.node.mjs
 1.8KB -
✅ subscribable/dist/index.native.mjs
 1.75KB -
✅ subscribable/dist/index.browser.mjs
 1.74KB -
✅ rpc-transport-http/dist/index.node.mjs
 1.72KB -
✅ rpc-types/dist/index.browser.mjs
 1.53KB -
✅ rpc-types/dist/index.native.mjs
 1.53KB -
✅ rpc-types/dist/index.node.mjs
 1.53KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.node.mjs
 1.33KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.native.mjs
 1.27KB -
✅ rpc-subscriptions-channel-websocket/dist/inde
x.browser.mjs
 1.26KB -
✅ program-client-core/dist/index.browser.mjs
 1.21KB -
✅ program-client-core/dist/index.native.mjs
 1.21KB -
✅ program-client-core/dist/index.node.mjs
 1.21KB -
✅ options/dist/index.browser.mjs
 1.18KB -
✅ options/dist/index.native.mjs
 1.18KB -
✅ options/dist/index.node.mjs
 1.17KB -
✅ accounts/dist/index.browser.mjs
 1.17KB -
✅ accounts/dist/index.native.mjs
 1.17KB -
✅ accounts/dist/index.node.mjs
 1.16KB -
✅ rpc-api/dist/index.browser.mjs
 976B -
✅ rpc-api/dist/index.native.mjs
 975B -
✅ rpc-api/dist/index.node.mjs
 973B -
✅ compat/dist/index.browser.mjs
 969B -
✅ compat/dist/index.native.mjs
 968B -
✅ compat/dist/index.node.mjs
 966B -
✅ rpc-spec-types/dist/index.browser.mjs
 962B -
✅ rpc-spec-types/dist/index.native.mjs
 961B -
✅ rpc-spec-types/dist/index.node.mjs
 959B -
✅ rpc-subscriptions-api/dist/index.native.mjs
 870B -
✅ rpc-subscriptions-api/dist/index.node.mjs
 869B -
✅ rpc-subscriptions-api/dist/index.browser.mjs
 868B -
✅ rpc-spec/dist/index.browser.mjs
 852B -
✅ rpc-spec/dist/index.native.mjs
 851B -
✅ rpc-spec/dist/index.node.mjs
 850B -
✅ promises/dist/index.browser.mjs
 799B -
✅ promises/dist/index.native.mjs
 798B -
✅ promises/dist/index.node.mjs
 797B -
✅ assertions/dist/index.browser.mjs
 783B -
✅ instructions/dist/index.browser.mjs
 771B -
✅ instructions/dist/index.native.mjs
 770B -
✅ instructions/dist/index.node.mjs
 768B -
✅ fast-stable-stringify/dist/index.browser.mjs
 726B -
✅ fast-stable-stringify/dist/index.native.mjs
 725B -
✅ assertions/dist/index.native.mjs
 724B -
✅ fast-stable-stringify/dist/index.node.mjs
 724B -
✅ assertions/dist/index.node.mjs
 723B -
✅ programs/dist/index.browser.mjs
 329B -
✅ plugin-core/dist/index.browser.mjs
 328B -
✅ programs/dist/index.native.mjs
 327B -
✅ plugin-core/dist/index.native.mjs
 326B -
✅ programs/dist/index.node.mjs
 325B -
✅ plugin-core/dist/index.node.mjs
 324B -
✅ event-target-impl/dist/index.node.mjs
 230B -
✅ functional/dist/index.browser.mjs
 154B -
✅ functional/dist/index.native.mjs
 152B -
✅ text-encoding-impl/dist/index.native.mjs
 152B -
✅ functional/dist/index.node.mjs
 151B -
✅ codecs/dist/index.browser.mjs
 137B -
✅ codecs/dist/index.native.mjs
 136B -
✅ codecs/dist/index.node.mjs
 134B -
✅ event-target-impl/dist/index.browser.mjs
 133B -
✅ ws-impl/dist/index.node.mjs
 131B -
✅ text-encoding-impl/dist/index.browser.mjs
 122B -
✅ text-encoding-impl/dist/index.node.mjs
 119B -
✅ ws-impl/dist/index.browser.mjs
 113B -
✅ crypto-impl/dist/index.node.mjs
 111B -
✅ crypto-impl/dist/index.browser.mjs
 109B -
✅ rpc-parsed-types/dist/index.browser.mjs
 66B -
✅ rpc-parsed-types/dist/index.native.mjs
 65B -
✅ rpc-parsed-types/dist/index.node.mjs
 63B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 12, 2026

Documentation Preview: https://kit-docs-adb1h1txx-anza-tech.vercel.app

lorisleiva
lorisleiva approved these changes Feb 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this. 🍺

@mcintyre94 mcintyre94 added this pull request to the merge queue Feb 13, 2026
Merged via the queue into main with commit 4d839cf Feb 13, 2026
12 checks passed
@mcintyre94 mcintyre94 deleted the menu-fix branch February 13, 2026 10:04
@mcintyre94 mcintyre94 mentioned this pull request Feb 13, 2026
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 2, 2026

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lorisleiva lorisleiva lorisleiva approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcintyre94 @lorisleiva