chore: rename library to prettier-modals#3
Merged
Conversation
Rebrand the project from "Pretty Modal" to "Prettier Modals" ahead of detaching it from the fork network, keeping the original MIT license intact for legal compliance. - npm packages: pretty-modal -> prettier-modals, pretty-modal-angular -> prettier-modals-angular (package.json names, workspace scripts, peer dep, demo file: deps, import specifiers, the vitest mock and the core import in the Angular service). - READMEs: display name, install/usage snippets, repository/clone URLs (now antuuanyf/prettier-modals). - Attribution: package.json author and README footers/credits now name Antonio Monreal Diaz. The original MIT license block in packages/core/README.md keeps "Copyright (c) 2026 srdavo", and the credits acknowledge the original work by srdavo. Public API symbols (PrettyModal, PrettyModalService, the directives) and the injected CSS classes (pretty-modal-*) are intentionally unchanged: renaming them would be a breaking API/behavior change, not a rename. Verified: core 15/15 + Angular wrapper 13/13 tests pass, and the Angular demo builds against the renamed packages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add LICENSE (MIT) at the repo root and in each publishable package (packages/core, packages/angular) so the original "Copyright (c) 2026 srdavo" notice ships with every distribution, as MIT requires. Verified the file is included: `npm pack` for the core and ng-packagr's dist for the Angular wrapper both contain LICENSE. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Rebranding del proyecto Pretty Modal → Prettier Modals, de cara a sacarlo de la red de forks. Mantiene la licencia MIT original intacta para que todo sea legal.
Cambios
Nombres de paquete npm
pretty-modal→prettier-modalspretty-modal-angular→prettier-modals-angularpackage.json(nombres, scripts-w, peer dep,file:deps de la demo), import specifiers, elvi.mockdel test y el import del core en el servicio Angular.READMEs
antuuanyf/prettier-modals).Atribución / licencia
authorde lospackage.jsony los footers/credits de los READMEs → Antonio Monreal Diaz.packages/core/README.mdmantieneCopyright (c) 2026 srdavo(licencia original).Fuera de alcance (a propósito)
Los símbolos públicos de la API (
PrettyModal,PrettyModalService, las directivas) y las clases CSS inyectadas (pretty-modal-*) no se renombran: hacerlo sería un cambio de API/comportamiento que rompería el demo vanilla y los e2e. Si lo quieres, lo hacemos en un PR aparte.Tampoco se tocan
docs/niAGENTS.md(notas internas) ni los remotes de git (el repo aún no está renombrado en GitHub).Verificación
npm install+ng buildOK)🤖 Generated with Claude Code