feat(core): bump default animation duration to 0.5s (v0.1.1)#10
Merged
Conversation
The slightly longer default reads better on open/close. Release as prettier-modals 0.1.1; the Angular wrapper is unchanged (its peerDependency ^0.1.0 already covers 0.1.1). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the default
durationof the open/close animation from 0.4s → 0.5s in the vanilla core. The slightly longer default reads better when the modal morphs in and out.Why
Tuning pass on the open/close feel — the longer default makes the morph settle more smoothly. No new options, no API surface change; existing callers passing an explicit
durationare unaffected.Scope
prettier-modals(core):0.1.0 → 0.1.1— single-line default change + version bump.prettier-modals-angular(wrapper): unchanged. It has no code change and itspeerDependency^0.1.0already covers0.1.1, so it is not republished.Verification
npm run build:core✅npm test -w prettier-modals✅ (15/15)Release steps (after merge)
git tag v0.1.1 && git push origin v0.1.1→ triggersrelease.yml(packs tarballs + GitHub Release).npm publishthe core only (packages/core). Angular 0.1.0 stays as published.🤖 Generated with Claude Code