Added return of actual operation in LogiLEDWrapper#2054
Added return of actual operation in LogiLEDWrapper#2054diogotr7 merged 4 commits intoantonpup:devfrom supergrml:logiloading
Conversation
|
I dont understand what you're trying to solve here? The wrapper is for logitech games, not devices. This is never used for connecting to LGHUB or LGS from Aurora. The purpose of the wrapper is acting as a replacement to LGS to the eyes of, for example, GTA 5. This allows aurora to capture the lighting intended for logitech devices and display it somewhere else. |
|
If you lose connection to the device or GHub/LGS the wrapper doesn't return an appropriate result. The LogitechLed gives back the right status, this change is meant to be consistent. |
|
This issue does not solve #1953 at all but the wrapper changes do make sense... I'll take the opportunity to fix an issue i found with the wrapper light event while testing the changes. Thank you for contributing. |
this happens when the user opens an application with a wrapper (for example terraria with the logitech wrapper enabled) since Application doesn't exist in this scenario. Dirty fix for now, should fix properly
Related to: #1953
List any issues that this PR fixes: fixes # , etc...
This pull request proposes the following changes:
Known issues/To do: