Audio device picker#2028
Merged
diogotr7 merged 7 commits intoantonpup:devfrom Jun 2, 2020
Wibble199:feature/audio-device-picker
Merged
Audio device picker#2028diogotr7 merged 7 commits intoantonpup:devfrom Wibble199:feature/audio-device-picker
diogotr7 merged 7 commits intoantonpup:devfrom
Wibble199:feature/audio-device-picker
Conversation
Helps with easily swapping devices on-the-fly.
…or the local pc inf game state. Changing the gamestate device requires a restart.
This allows re-creating the MMDevice on the correct thread. The device is only recreated if the ID has changed, so the only overheard of calling it each frame is a string comparison.
How dumb am I to not notice this bug at first... :(
diogotr7
approved these changes
Jun 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to select which audio device to use for individual audio visualizer layers and globally for the local pc information game state.