Miscellaneous fixes#1983
Merged
diogotr7 merged 9 commits intoantonpup:devfrom Apr 28, 2020
Wibble199:fixes/miscellaneous
Merged
Miscellaneous fixes#1983diogotr7 merged 9 commits intoantonpup:devfrom Wibble199:fixes/miscellaneous
diogotr7 merged 9 commits intoantonpup:devfrom
Wibble199:fixes/miscellaneous
Conversation
Set at 90, which means a maximum arc of 4 degrees. Even at around 20 segements though, it's still barely noticable. This is more to prevent people crashing it by setting a studpidly high number.
…ence was changed in the keysequence control by a binding. This commit fixes the issues with a region not being removed from the layer editor when a preset is applied on the particle layer and also the issue with the checkbox not being set correctly initially on the radial layer control. For future reference for anyone reading this: When needing custom code to run when a dependency property's value is updated, this should always be done in a dedicated changed handler, NOT the property setter method. This is because changes to bindings do not actually set the property and thus would not invoke custom code on the property setter.
Now that there is no dropdown saying what type an evaluatable is, the labels need to make it clear instead.
diogotr7
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small fixes for some of the newer things: