Skip to content

Ducky Keyboard Support#1892

Merged
diogotr7 merged 13 commits intoantonpup:devfrom
Lexevolution:feature/ducky-shine-7-support
Feb 22, 2020
Merged

Ducky Keyboard Support#1892
diogotr7 merged 13 commits intoantonpup:devfrom
Lexevolution:feature/ducky-shine-7-support

Conversation

@Lexevolution
Copy link
Contributor

@Lexevolution Lexevolution commented Jan 23, 2020

List any issues that this PR fixes: fixes # , etc...

Fixes #1391

This pull request proposes the following changes:

  • Adds these Ducky keyboards:
    • Ducky Shine 7
    • Ducky One 2 RGB
    • Ducky One 2 RGB TKL

Known issues/To do:

  • This does NOT include support for the Ducky One 2 Mini. That keyboard can never be supported due to there being no rgb communication between the keyboard and the PC.

@Lexevolution
Copy link
Contributor Author

Lexevolution commented Feb 2, 2020

I've added ISO support now. Just need someone to test. It's difficult finding someone with this keyboard that has the ISO layout, since almost everyone has the ANSI one... 99% sure it's correct though.

@Lexevolution Lexevolution requested a review from diogotr7 February 2, 2020 05:40
diogotr7
diogotr7 previously approved these changes Feb 8, 2020
@diogotr7 diogotr7 requested a review from Wibble199 February 8, 2020 00:03
@Lexevolution Lexevolution changed the title Ducky Shine 7 Keyboard Support Ducky Keyboard Support Feb 16, 2020
@diogotr7 diogotr7 merged commit cf168fe into antonpup:dev Feb 22, 2020
@Lexevolution Lexevolution deleted the feature/ducky-shine-7-support branch February 23, 2020 03:36
@Lexevolution Lexevolution restored the feature/ducky-shine-7-support branch February 23, 2020 03:36
@Lexevolution Lexevolution deleted the feature/ducky-shine-7-support branch February 23, 2020 03:41
@diogotr7 diogotr7 mentioned this pull request Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants