Fix uncommon crash when deleting custom profile#1880
Merged
diogotr7 merged 2 commits intoantonpup:devfrom Jan 11, 2020
Wibble199:fix/custom-profile-delete-crash
Merged
Fix uncommon crash when deleting custom profile#1880diogotr7 merged 2 commits intoantonpup:devfrom Wibble199:fix/custom-profile-delete-crash
diogotr7 merged 2 commits intoantonpup:devfrom
Wibble199:fix/custom-profile-delete-crash
Conversation
This sometimes occured when the previous profile in the list was hidden and the user had not shown the hidden profiles. Aurora would then select the item before the one deleted and try to get the average color of the bitmap and crash (perhaps since the resource hadn't been loaded?). Now selects the previously non-hidden profile.
diogotr7
approved these changes
Jan 10, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes occasional crash when deleting a custom profile.
This sometimes occured when the previous profile in the list was hidden and the user had not shown the hidden profiles. Aurora would then try to select the item before the one deleted and try to get the average color of the profile's icon and crash (perhaps since the resource hadn't been loaded or something?).
Now, when deleting a profile, it will select the next non-hidden profile.