Skip to content

Added BetterDiscord support with a plugin#1708

Merged
simon-wh merged 16 commits intoantonpup:devfrom
diogotr7:feature/discord
Dec 20, 2019
Merged

Added BetterDiscord support with a plugin#1708
simon-wh merged 16 commits intoantonpup:devfrom
diogotr7:feature/discord

Conversation

@diogotr7
Copy link
Collaborator

Adds support for discord status information. Uses only overlays, the regular layers are disabled by default.

Thanks to @Popat0 for writing most of the plugin.

@diogotr7 diogotr7 changed the base branch from release/v0.7 to dev October 16, 2019 17:00
onLibLoaded() {

this.settings = NeatoLib.Settings.load(this, this.defaultSettings);
NeatoLib.Updates.check(this, "https://raw.githubusercontent.com/Popat0/Discord-GSI/master/AuroraGSI.plugin.js");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you want another update check in the js code? Either use the pluginrepo from BD or do the update check here in C#

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do realize not everyone uses PluginRepo, right? As for Aurora it only is supposed to install the plugin for a first run, not check if it's up to date.

Bluscream
Bluscream previously approved these changes Nov 11, 2019
Copy link

@Bluscream Bluscream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through, couldn't find anything major

simon-wh
simon-wh previously approved these changes Dec 15, 2019
@simon-wh simon-wh merged commit b36dddd into antonpup:dev Dec 20, 2019
@diogotr7 diogotr7 deleted the feature/discord branch December 20, 2019 18:05
@Bluscream
Copy link

OwO finally lul

@Bentechy66
Copy link

Plugin appears to be broken. Console output:
image

@Bentechy66
Copy link

Plugin appears to be broken. Console output:
image

Fixed

@Popat0
Copy link

Popat0 commented Dec 25, 2019

Plugin appears to be broken. Console output:

Attempted a fix by updating the library a couple hours ago, unsure if it worked due to an acute case of lack of computer. Restarting Discord is enough to get the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants