Move accept logic to a goroutine so it becomes non-blocking#345
Merged
antoniomika merged 1 commit intomainfrom Apr 10, 2025
Merged
Move accept logic to a goroutine so it becomes non-blocking#345antoniomika merged 1 commit intomainfrom
antoniomika merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
utils/state.go:192
- [nitpick] The call to CopyBoth is now executed synchronously inside the goroutine. Please ensure that this blocking call does not hinder desired concurrent processing or overall performance.
CopyBoth(conn, cl)
| } | ||
| if err != nil || pL.State.IPFilter.Blocked(clientRemote) { | ||
| cl.Close() | ||
| return pL.Accept() |
There was a problem hiding this comment.
Replacing the loop 'continue' with a recursive call may risk a stack overflow in situations of repeated accept errors. Consider refactoring to a loop-based error recovery mechanism to ensure long-term stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move accept logic to a goroutine so it becomes non-blocking