Antoinekm/no follow followers by antoinekm · Pull Request #2 · antoinekm/charognard

antoinekm · 2025-12-26T00:06:02Z

Summary by CodeRabbit

New Features
- Added "Skip Followers" toggle in settings to exclude existing followers from mass-follow operations.
- Added "Remove from list" action on followed profiles (with tooltip) to remove from lists while keeping follow state.
- Mass-follow now respects the skip setting and shows a notification with how many users were skipped.
Style
- Increased toast stacking order to ensure notifications and tooltips appear above other UI layers.
Chores
- Version bumped to 0.2.0.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-26T00:06:10Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Adds a "skip followers" feature that prevents following users who already follow you during mass-follow; includes a settings toggle, storage defaults/migrations, friendship checks in the mass-follow flow with skipped-count reporting, a Remove-from-list action, increased toast z-index, and a package version bump.

Changes

Cohort / File(s)	Summary
Toast styling `components/ui/toast.tsx`	Increased z-index values from `z-50` to `z-10001` for toast viewport/positioner.
Limits & Settings UI `entrypoints/content/components/side-panel/settings/limits-section.tsx`, `entrypoints/content/side-panel/settings.tsx`	Added `skipFollowers` boolean, `onSkipFollowersChange` handler, UI toggle in LimitsSection, wired setting load/save/reset and live updates in SettingsTab.
Followed list UI `entrypoints/content/side-panel/followed.tsx`	Added Remove-from-list action with `XIcon` and tooltip; new handler to remove a profile from the followed list (keeps following).
Mass-follow logic `entrypoints/content/side-panel/suggestions.tsx`	Read `skipFollowers` setting during mass-follow; check friendship status per user, skip users who already follow you, track skipped count, and show an info toast if any skipped.
Storage & exports `lib/storage.ts`	Added `skipFollowers` to `UserSettings`, introduced `DEFAULT_SKIP_FOLLOWERS = true`, included in default data and migrations, exported constant.
Versioning `package.json`	Bumped `version` to `0.2.0`; added `version:patch`, `version:minor`, `version:major` npm scripts.

Sequence Diagram

sequenceDiagram
    participant User
    participant SettingsUI as Settings UI
    participant Storage
    participant Suggestions as Mass-Follow Handler
    participant InstagramAPI as Instagram API
    participant Toast

    User->>SettingsUI: Toggle "Skip Followers"
    SettingsUI->>Storage: save(skipFollowers)
    Storage-->>SettingsUI: ack

    User->>Suggestions: start mass-follow(selectedUsers)
    Suggestions->>Storage: read(skipFollowers)
    Storage-->>Suggestions: return skipFollowers

    loop for each user
        alt skipFollowers == true
            Suggestions->>InstagramAPI: getFriendshipStatus(user)
            InstagramAPI-->>Suggestions: followsMe? (yes/no)
            alt yes
                Suggestions->>Suggestions: skip user (remove, ++skippedCount)
            else no
                Suggestions->>InstagramAPI: follow(user)
                InstagramAPI-->>Suggestions: follow result
            end
        else
            Suggestions->>InstagramAPI: follow(user)
            InstagramAPI-->>Suggestions: follow result
        end
    end

    Suggestions->>Toast: show("X users skipped") when skippedCount > 0
    Toast-->>User: display notification

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I nudge the toggle, nimble and sly,
Skip those who follow — no need to try.
Toasts leap higher so messages gleam,
Lists trimmed neat, and the mass-follow's clean.
Version bumped up — hop onward we beam!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'Antoinekm/no follow followers' directly relates to the main feature: adding ability to skip users who already follow you during mass-follow operations.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch antoinekm/no-follow-followers

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2350d8 and 65a6e80.

📒 Files selected for processing (1)

entrypoints/content/side-panel/suggestions.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

entrypoints/content/side-panel/suggestions.tsx

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR introduces a "skip existing followers" feature for the mass-follow operation and adds quality-of-life improvements to the extension. The version is bumped from 0.1.0 to 0.2.0 to reflect these new capabilities.

Key changes:

Adds a new setting to skip users who already follow you during mass-follow operations
Introduces ability to remove users from the followed list without unfollowing them on Instagram
Adds npm scripts for versioning workflow automation

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
package.json	Bumps version to 0.2.0 and adds versioning scripts for patch, minor, and major releases
lib/storage.ts	Adds `skipFollowers` setting with default value `true` and migration logic for existing users
entrypoints/content/side-panel/suggestions.tsx	Implements skip followers logic in mass-follow operation with friendship status check and user feedback
entrypoints/content/side-panel/settings.tsx	Adds state management for the skip followers setting in the settings UI
entrypoints/content/side-panel/followed.tsx	Adds "remove from list" functionality with new UI button to remove users without unfollowing
entrypoints/content/components/side-panel/settings/limits-section.tsx	Adds toggle switch UI control for the skip followers setting
components/ui/toast.tsx	Updates z-index from z-50 to z-10001 for toast components

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

entrypoints/content/side-panel/suggestions.tsx

components/ui/toast.tsx

entrypoints/content/side-panel/suggestions.tsx

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (2)

package.json (1)

16-18: Consider cross-platform compatibility for version scripts.

The version scripts use shell command substitution which requires bash/zsh. These may not work on Windows without WSL or Git Bash. Consider using a cross-platform solution (e.g., cross-env, tsx script) or document the bash requirement.

Alternative: Cross-platform version script using Node.js

Create scripts/version.js:

#!/usr/bin/env node
const { execSync } = require('child_process');
const { readFileSync } = require('fs');

const level = process.argv[2];
if (!['patch', 'minor', 'major'].includes(level)) {
  console.error('Usage: node scripts/version.js <patch|minor|major>');
  process.exit(1);
}

execSync(`npm version ${level} --no-git-tag-version`, { stdio: 'inherit' });
const pkg = JSON.parse(readFileSync('./package.json', 'utf8'));
execSync(`git add package.json && git commit -m "🔖 release v${pkg.version}"`, { stdio: 'inherit' });

Then update package.json:

-"version:patch": "npm version patch --no-git-tag-version && git add package.json && git commit -m \"🔖 release v$(node -p \"require('./package.json').version\")\"",
-"version:minor": "npm version minor --no-git-tag-version && git add package.json && git commit -m \"🔖 release v$(node -p \"require('./package.json').version\")\"",
-"version:major": "npm version major --no-git-tag-version && git add package.json && git commit -m \"🔖 release v$(node -p \"require('./package.json').version\")\""
+"version:patch": "node scripts/version.js patch",
+"version:minor": "node scripts/version.js minor",
+"version:major": "node scripts/version.js major"

entrypoints/content/side-panel/suggestions.tsx (1)

177-192: Consider increasing delay between friendship checks.

The skip logic correctly checks followed_by status before following. However, the delay (500-1000ms) is significantly shorter than the post-follow delay (2000-4000ms). If many users are skipped in succession, this could trigger Instagram's rate limiting on friendship status checks.
Recommended: Increase delay to match follow cadence
           if (friendshipStatus.followed_by) {
             // User already follows us, skip them
             setSelectedUsers((prev) => {
               const next = new Set(prev);
               next.delete(suggestion.user.pk);
               return next;
             });
             skippedCount++;
             // Small delay before checking next user
-            await new Promise((resolve) => setTimeout(resolve, 500 + Math.random() * 500));
+            await new Promise((resolve) => setTimeout(resolve, 1500 + Math.random() * 1000));
             continue;
           }

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85d7fb6 and b2350d8.

📒 Files selected for processing (7)

components/ui/toast.tsx
entrypoints/content/components/side-panel/settings/limits-section.tsx
entrypoints/content/side-panel/followed.tsx
entrypoints/content/side-panel/settings.tsx
entrypoints/content/side-panel/suggestions.tsx
lib/storage.ts
package.json

🧰 Additional context used

📓 Path-based instructions (4)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Store centralized app constants (name, short name, developer info) in constants/app.ts and reference via APP.NAME, APP.SHORT_NAME, etc.
Define shared TypeScript types for API responses and messages in lib/types.ts
Implement Instagram API functions (fetchSuggestions, followUser, unfollowUser, checkFollowStatus) in lib/instagram.ts
Implement browser storage with multi-account support in lib/storage.ts, scoped per Instagram user ID with daily limits reset at midnight
Implement background automation logic in lib/automation.ts
Use coss/ui components (Button, Avatar, ScrollArea, etc.) from components/ui/ for consistent styling with Tailwind CSS v4
Include x-csrftoken header from cookies and x-ig-app-id: 936619743392459 in all Instagram API requests

Files:

entrypoints/content/side-panel/followed.tsx
entrypoints/content/components/side-panel/settings/limits-section.tsx
components/ui/toast.tsx
lib/storage.ts
entrypoints/content/side-panel/settings.tsx
entrypoints/content/side-panel/suggestions.tsx

entrypoints/content/side-panel/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Organize tab components (suggestions, followed, settings) in entrypoints/content/side-panel/

Files:

entrypoints/content/side-panel/followed.tsx
entrypoints/content/side-panel/settings.tsx
entrypoints/content/side-panel/suggestions.tsx

entrypoints/content/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Inject main content script UI into *.instagram.com/* via Shadow DOM from entrypoints/content/

Files:

entrypoints/content/side-panel/followed.tsx
entrypoints/content/components/side-panel/settings/limits-section.tsx
entrypoints/content/side-panel/settings.tsx
entrypoints/content/side-panel/suggestions.tsx

entrypoints/content/components/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Place reusable UI components for content script in entrypoints/content/components/

Files:

entrypoints/content/components/side-panel/settings/limits-section.tsx

🧠 Learnings (11)

📓 Common learnings

Learnt from: CR
Repo: antoinekm/charognard PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-12-25T23:33:42.465Z
Learning: Track followed profiles, daily action counts, and automation settings in browser storage with separate daily limits for follow and unfollow actions resetting at midnight