Skip to content

Extract FileUtils updates by @ericvergnaud#4030

Merged
parrt merged 1 commit into
antlr:devfrom
parrt:eric-fileutils-update
Dec 20, 2022
Merged

Extract FileUtils updates by @ericvergnaud#4030
parrt merged 1 commit into
antlr:devfrom
parrt:eric-fileutils-update

Conversation

@parrt

@parrt parrt commented Dec 20, 2022

Copy link
Copy Markdown
Member

Extract FileUtils updates by @ericvergnaud in #4027 then he can rebase after we merge this into dev. All tests pass locally (didn't check python2 actually but python3 works).

Signed-off-by: Terence Parr parrt@antlr.org

…rebase after we merge this into dev. All tests pass locally (didn't check python2 actually but python3 works).

Signed-off-by: Terence Parr <parrt@antlr.org>
@parrt

parrt commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

@ericvergnaud ready for your review once tests pass. Then we can merge before ts.

@parrt parrt mentioned this pull request Dec 20, 2022
Comment thread runtime-testsuite/test/org/antlr/v4/test/runtime/FileUtils.java
@parrt parrt merged commit 0828d53 into antlr:dev Dec 20, 2022
@parrt

parrt commented Dec 20, 2022

Copy link
Copy Markdown
Member Author

During tests setup, the Antlr package is webpacked.
For each test, that package is installed as a dependency of the project in node_modules, using npm link.
Without this change, the antlr package gets deleted as part of destroying the test folder, which makes all subsequent tests fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants