Skip to content

Get rid of reflection in Go.stg#3353

Merged
parrt merged 1 commit into
antlr:masterfrom
KvanTTT:go-improvements
Dec 13, 2021
Merged

Get rid of reflection in Go.stg#3353
parrt merged 1 commit into
antlr:masterfrom
KvanTTT:go-improvements

Conversation

@KvanTTT

@KvanTTT KvanTTT commented Nov 14, 2021

Copy link
Copy Markdown
Member

fixes #2278

@jjeffcaii @ericvergnaud please review

@jjeffcaii jjeffcaii left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KvanTTT

KvanTTT commented Dec 13, 2021

Copy link
Copy Markdown
Member Author

@parrt please merge.

@parrt parrt added this to the 4.9.4 milestone Dec 13, 2021
@parrt parrt merged commit 5d6a782 into antlr:master Dec 13, 2021
@parrt

parrt commented Dec 13, 2021

Copy link
Copy Markdown
Member

thanks!

@KvanTTT KvanTTT deleted the go-improvements branch December 13, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use of reflect.TypeOf slows down Go execution by 33%

3 participants