[Python] Fix index when combining inserts#3205
Open
JamesHutch wants to merge 1 commit into
Open
Conversation
prevInserts list is the subset of rewrites, so indices taken from enumerating its elements do not correspond to the correct indices in rewrites. Use prevIop.instructionIndex instead, which matches the other runtimes.
Contributor
|
@lygav as original writer of this code, can you check whether this fix is ok ? |
Contributor
|
Hi @JamesHutch , can you write a test to demonstrate the issue and verify the solution? |
Closed
Member
|
I'm going to leave this for after 4.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevInserts list is the subset of rewrites, so indices taken from
enumerating its elements do not correspond to the correct indices in
rewrites. Use prevIop.instructionIndex instead, which matches the other
runtimes.