Skip to content

Fixed TextIO compatibility with 3.6+#2613

Merged
parrt merged 3 commits into
antlr:masterfrom
ImanHosseini:patch-1
Sep 10, 2019
Merged

Fixed TextIO compatibility with 3.6+#2613
parrt merged 3 commits into
antlr:masterfrom
ImanHosseini:patch-1

Conversation

@ImanHosseini

Copy link
Copy Markdown
Contributor

Fixing this issue: #2611 (and probably #2193)
TextIO has moved since Python 3.6 so it should be imported considering the change for new versions.

[I have signed contributor's file: https://github.com//pull/2612]

Fixing this issue: #2611 (and probably #2193)
TextIO has moved since Python 3.6 so it should be imported considering the change for new versions.
@michaeljquinn

Copy link
Copy Markdown

When can we get this fix into PyPi

I need this for my app,

@ericvergnaud

Copy link
Copy Markdown
Contributor

@parrt blessed

@ericvergnaud

ericvergnaud commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

@ImanHosseini you need to add yourself to the contributors list for this PR to make it.
#2612 is closed so better you do it as part of this PR.

@michaeljquinn

Copy link
Copy Markdown

cool, good to hear !!!

@ImanHosseini

Copy link
Copy Markdown
Contributor Author

@ImanHosseini you need to add yourself to the contributors list for this PR to make it.
#2612 is closed so better you do it as part of this PR.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants