Skip to content

Revert "fix(zsh): use global scope for typeset to support lazy loading"#2810

Merged
tusharmath merged 1 commit intomainfrom
revert-2776-fix/zsh-lazy-loading
Apr 2, 2026
Merged

Revert "fix(zsh): use global scope for typeset to support lazy loading"#2810
tusharmath merged 1 commit intomainfrom
revert-2776-fix/zsh-lazy-loading

Conversation

@ssddOnTop
Copy link
Copy Markdown
Collaborator

Reverts #2776

@github-actions github-actions bot added the type: fix Iterations on existing features or infrastructure. label Apr 2, 2026
@tusharmath tusharmath enabled auto-merge (squash) April 2, 2026 22:45
@tusharmath tusharmath merged commit 4add7e1 into main Apr 2, 2026
11 checks passed
@tusharmath tusharmath deleted the revert-2776-fix/zsh-lazy-loading branch April 2, 2026 22:45
@losinggeneration
Copy link
Copy Markdown
Contributor

@ssddOnTop Could you please describe the problem that people were seeing with this? I'd love to know why this was reverted. I assume there were issues reported, but I don't see them linked here or noted as a comment if they were reported somewhere else.

@losinggeneration
Copy link
Copy Markdown
Contributor

OK, so I dropped into discord to ask there, where it was reported. Essentially, RPROMPT resolves to $(_forge_prompt_info) with this commit. Adding setopt PROMPT_SUBST fixes this, but I'm wanting to investigate some more to see if there's an alternative solution to this, because it seems a bit intrusive to arbitrarily setopt PROMPT_SUBST for users. I already had PROMPT_SUBST included in my configuration, which is why I never saw this as an issue during my testing. It wasn't until I loaded a minimal zshrc that I was able to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Iterations on existing features or infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants