perf(workspace): improve workspace sync performance#2787
Merged
tusharmath merged 8 commits intomainfrom Apr 2, 2026
Merged
Conversation
…ndant file collection
tusharmath
commented
Apr 2, 2026
| .collect(); | ||
|
|
||
| /// - `paths_to_upload`: Vector of absolute local file paths to upload | ||
| pub fn get_sync_paths(&self, local_hashes: Vec<FileHash>) -> (Vec<String>, Vec<String>) { |
Collaborator
Author
There was a problem hiding this comment.
Lets use PathBuf instead of String to depict that these are paths. Create a struct to wrap and have proper names - delete: Vec<PathBuf> and upload: Vec<PathBuf>. Reuse an existing type if already exists.
tusharmath
commented
Apr 2, 2026
dfec1e5 to
493d343
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2630 #2497