Merged
Conversation
Contributor
amitksingh1490
commented
Mar 9, 2026
- feat(task): add task tool for agent delegation with session resumption
- feat(task): capitalize task tool name and prevent self-delegation in task tool
- style(tests): reformat function call arguments to comply with line width limits
...ge_repo__provider__openai_responses__request__tests__openai_responses_all_catalog_tools.snap
Show resolved
Hide resolved
216182d to
347c295
Compare
|
Action required: PR inactive for 5 days. |
|
Action required: PR inactive for 5 days. |
…sensitivity handling
…rove partitioning logic
|
Action required: PR inactive for 5 days. |
Confirmed:
|
tusharmath
reviewed
Apr 5, 2026
| .into_iter() | ||
| .zip(task_calls.iter()) | ||
| .map(|(result, tc)| ((*tc).clone(), result)) | ||
| .collect(); |
Collaborator
There was a problem hiding this comment.
Toolcall should simply offload the call to the toolexecutor. We are doing too much work here to process and prepare the toolcall params.
tusharmath
reviewed
Apr 5, 2026
| agent_id: AgentId, | ||
| task: String, | ||
| ctx: &ToolCallContext, | ||
| conversation_id: Option<String>, |
Collaborator
There was a problem hiding this comment.
Suggested change
| conversation_id: Option<String>, | |
| conversation_id: Option<ConversationId>, |
Can use ConversationId directly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.