Add partial AVX512 Linux support for dot product on 4-bit quantized values#80
Closed
Ameobea wants to merge 2 commits intoantimatter15:masterfrom
Ameobea:avx512-support
Closed
Add partial AVX512 Linux support for dot product on 4-bit quantized values#80Ameobea wants to merge 2 commits intoantimatter15:masterfrom Ameobea:avx512-support
Ameobea wants to merge 2 commits intoantimatter15:masterfrom
Ameobea:avx512-support
Conversation
* Update Makefile to detect AVX512 support and add compiler flags if it's available * Based on existing AVX2 implementation, dot product on one 32-value block of 4-bit quantized ints at a time * Perform 8 bit -> 16 bit sign extension and multiply+add on 32 values at time instead of 16 * Use built-in AVX512 horizontal reduce add to get sum at the end
* Manual unrolling on inner dot product loop to reduce loop counter overhead * Add some extra AVX512 compiler flags if detected in makefile
Owner
|
Looks great! That said, I'm working on trying to minimize the number of deviations from the upstream https://github.com/ggerganov/llama.cpp repo, so there would be a more appropriate place for this PR! |
Author
|
Yeah I'll get a PR up there tomorrow as well. In the meantime, if anyone else has access to Linux with AVX512-capable CPUs, would be great if they could test this to make sure it works on their setups as well. |
Author
|
Created ggml-org#320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Performance Impact
I'm seeing around 10% speedup on the 4-bit quantized 7B model when running on my AMD 7950x.
Before:
After:
I was hoping for more, but some other stuff I tried like converting the
bytesFromNibblesfunction to operate on two blocks at a time by using AVX512 were not successful.