fix: strip shell comments before parsing claude_args#1027
Open
Jah-yee wants to merge 1 commit intoanthropics:mainfrom
Open
fix: strip shell comments before parsing claude_args#1027Jah-yee wants to merge 1 commit intoanthropics:mainfrom
Jah-yee wants to merge 1 commit intoanthropics:mainfrom
Conversation
Prevents # characters in claude_args from swallowing subsequent flags. Shell-quote treats # as a shell comment, which breaks configurations where users add explanatory comments (e.g., --model followed by # comment and --allowed-tools). Fixes anthropics#802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents
#characters inclaude_argsfrom swallowing subsequent flags. Theshell-quotelibrary treats#as a shell comment character, which breaks configurations where users add explanatory comments.Problem
When users include shell-style comments in their
claude_args, all content after#is swallowed, including subsequent flags:The
--allowed-toolsflag is never parsed becauseshell-quotetreats everything after#as a comment.Solution
Strip shell-style comment lines (lines starting with
#after trimming) before parsing withshell-quote:Fixes
Fixes #802