fix(plugin-dev): support plugin wrapper format in validate-hook-schema.sh#13948
Open
kp222x wants to merge 1 commit intoanthropics:mainfrom
Open
fix(plugin-dev): support plugin wrapper format in validate-hook-schema.sh#13948kp222x wants to merge 1 commit intoanthropics:mainfrom
kp222x wants to merge 1 commit intoanthropics:mainfrom
Conversation
…a.sh
The validation script now correctly handles both hook configuration formats:
- Plugin wrapper format: {"description": "...", "hooks": {...}}
- Direct/settings format: {"PreToolUse": [...], ...}
Previously, the script would fail with jq errors when validating plugin
hooks.json files using the wrapper format that the skill itself recommends.
Changes:
- Detect wrapper format by checking for .hooks key
- Add helper function build_path() for constructing jq queries
- Validate optional description field in wrapper format
- Update all jq queries to use format-aware paths
Fixes anthropics#13292
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate-hook-schema.shscript to correctly handle both hook configuration formatshooks/hooks.jsonfiles using the wrapper format that the skill itself recommendsChanges
.hookskeybuild_path()for constructing format-aware jq queriesdescriptionfield in wrapper formatFormats Now Supported
Plugin wrapper format (now works):
{ "description": "Brief explanation", "hooks": { "PreToolUse": [...] } }Direct/settings format (still works):
{ "PreToolUse": [...] }Test Plan
Test Evidence
Wrapper format (the bug case):
Direct format (regression check):
Fixes #13292
🤖 Generated with Claude Code