Feature/external builder support#96
Merged
yankeeinlondon merged 62 commits intoantfu:mainfrom Jun 20, 2022
Merged
Conversation
feature: added better type hinting for Meta properties and Frontmatter properties fix: fix type errors found in "head.ts"
- refactored to better isolate builders and include clearer pipeline operation
…erComponent property is used or not
…to ensure full engagement with useHead functionality
…ality, and the frontmatter pre-processor refactor: improvements to happy-wrapper library and use of these improvements to improve the code builder's transform pipeline
chore: add test coverage testing refactor: removed shiki code
chore: attempts to get Cypress component tests working
- fix: fix type errors found in "head.ts" - test: cypress testing works in very limited way but not when running in "tabular layout" - test: vitest has been isolated from cypress symbol collisions - fix: removed cypress cruft from their install process - feature: added better type hinting for Meta properties and Frontmatter properties Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com> chore: update deps docs: update README.md (antfu#68) docs: import quote (antfu#70) fix: loss information from <script> in md chore: fix typo (antfu#73)
chore: started to add mechanism for Builders to declare dependencies on other builders
…blocks lines are brought into the singular block and in an order which ensures imports are first refactor: restructured some of the later stage block names in the builder pipeline to improve code readability and allow better testing chore: started to add "component tests" section which uses happy-dom; removed cypress for now
chore: make sure user can set styles but that default is always to NOT have styles test: add more component tests that test the end-state of being able to import frontmatter and excerpt variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Builder Support
When trying my first external builder I was embarrassed to find that several key symbols needed to develop externally were not being exported including
createBulider(). This has been addressed in this PR along with the following:Issues Closed
meta()builder but does now work as expected and tests have been addedhead()while usingmeta()builder; these have been resolved<PascalCase>components is converted to<kebab-case>before DOM API is used and thereby preserving name recognition in VueJS<script>blocks but was not working with multiple<script setup>blocks but not both work ... where<script>blocks are maintained 1:1 but<script setup>is rolled up into one and import statements are pushed to top of the blockTests
More tests were added and a few "component tests" were added using HappyDom. At the same time I have removed Cypress entirely for now.
Next Steps
The next PR will:
createBuilder()to allow for more bulletproof APIs