[5.0] fix IPv4 vs IPv6 mismatch in gelf_test#2288
Merged
spoonincode merged 1 commit intorelease/5.0from Mar 12, 2024
Merged
Conversation
heifner
approved these changes
Mar 6, 2024
Contributor
|
Note:start |
greg7mdp
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gelf_test.pylistens on 127.0.0.1,leap/tests/gelf_test.py
Lines 71 to 74 in aef4329
but then configured its
logging.jsonto uselocalhost. In 5.0, gelf will use IPv6 and on by boxlocalhostwill resolve to::1thus this test would fail locally for me since the gelf messages wouldn't arrive on the expected address.Explicitly configure
127.0.0.1in logging.json so it's always IPv4->IPv4