Skip to content

[4.0 -> 5.0] TraceAPI: Correctly convert return value via ABI#2248

Merged
heifner merged 7 commits intorelease/5.0from
GH-2228-return-value-5.0-merge
Feb 20, 2024
Merged

[4.0 -> 5.0] TraceAPI: Correctly convert return value via ABI#2248
heifner merged 7 commits intorelease/5.0from
GH-2228-return-value-5.0-merge

Conversation

@heifner
Copy link
Contributor

@heifner heifner commented Feb 20, 2024

  • Use action result type ABI for action return value conversion by ABI.
  • Only attempt conversion if an action return value ABI is available.
  • Updated tests to verify action return value handling.

Note: No replay of data is needed. trace_api_plugin was storing the data correctly on disk.

Merges release/4.0 into release/5.0 including #2246 & #2247

Resolves #2228

@heifner heifner requested review from greg7mdp and linh2931 February 20, 2024 19:50
@heifner heifner added the OCI Work exclusive to OCI team label Feb 20, 2024
@heifner heifner modified the milestones: Leap v5.0.1, Leap v5.0.2 Feb 20, 2024
@heifner heifner linked an issue Feb 20, 2024 that may be closed by this pull request
@heifner heifner merged commit 0590e02 into release/5.0 Feb 20, 2024
@heifner heifner deleted the GH-2228-return-value-5.0-merge branch February 20, 2024 20:29
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Correctly convert return value via ABI, allowing binary to variant conversation without crashing.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCI Work exclusive to OCI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_binary_to_variant function crashing on some blocks

4 participants