Return -1 on n==0 for bls_g1_weighted_sum, bls_g2_weighted_sum, and bls_pairing#254
Merged
Return -1 on n==0 for bls_g1_weighted_sum, bls_g2_weighted_sum, and bls_pairing#254
Conversation
…, and bls_pairing. Add return_code type.
linh2931
reviewed
Dec 6, 2023
| res.data(), res.size() | ||
| ); | ||
| } | ||
| if (num == 0) |
Contributor
There was a problem hiding this comment.
You might as well add a unit test for num == 0 as you are in this area.
linh2931
approved these changes
Dec 6, 2023
greg7mdp
reviewed
Dec 6, 2023
Contributor
greg7mdp
left a comment
There was a problem hiding this comment.
Why is this change needed? Wouldn't the internal functions return -1 as well if num == 0?
Contributor
Author
It simplifies the code. |
greg7mdp
approved these changes
Dec 6, 2023
arhag
approved these changes
Dec 6, 2023
Contributor
|
Note:start |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Return failure (-1) for
n==0forbls_g1_weighted_sum,bls_g2_weighted_sum, andbls_pairing.Added
return_codeenum for return code error codes forblsandalt_bn128and any others that use leap standardreturn_codeenum.API Changes
See description.
Documentation Additions
See description.
Resolves #253