feat: Cyrillic and Greek support #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengchun
reviewed
Jul 22, 2024
parse.go
Outdated
| (unicode.Is(first, r) || unicode.Is(second, r) || string(r) == "*") | ||
| (unicode.Is(first, r) || | ||
| unicode.Is(second, r) || | ||
| unicode.Is(cyrillic, r) || |
Contributor
There was a problem hiding this comment.
Why should we need add this new condition for cyrillic and greek. We already knows Non-English letters yet.
Contributor
|
Thanks for your work. I have some question about this code: unicode.Is(cyrillic, r) || unicode.Is(greek, r)Why should we need this condition. Removing this code still can works, I test now supports Non-English like Chinese or another language now. Thanks again. |
Author
|
Good catch. That was a leftover test from removed code. The idea was to allow certain charsets, but it’s better left to the user to decide post-parsing. I removed the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Greek and Cyrillic unicodes
This is done by tracking the byte count and correctly handling the multibyte strings
Added simple test for this