Add layout printers to the debugger and autogenerate tools/debug_printer#3
Conversation
goldfirere
left a comment
There was a problem hiding this comment.
I'm very happy to have more debug printers installed. I'm a little less convinced about the automation to refresh debug_printers: it constrains the way we write debug_printers.ml in a way that may prove annoying and counterintuitive later, for very little savings. And when things break, fixing it requires knowledge of awk. (Maybe that's widespread?)
In particular, I believe @ncik-roberts recently added something to debug_printers.ml that does not conform to this specification (in a branch). Is that accurate? But maybe it's better to put the printing code right in the compiler anyway? I'm really on the fence here.
|
I don't think that the debug printer I added will be problematic for Antal's change. It follows the format of other printers we list in |
|
I improved this by causing the automation to look only for lines that start with |
goldfirere
left a comment
There was a problem hiding this comment.
After merging, please put a PSA to the type systems group that this behavior has changed.
Looks good!
1df0b4a to
3fa5761
Compare
7e1bd64 to
faf1a53
Compare
|
I'll put out the PSA after ocaml-flambda#148 merges 👍 |
This improves the UX for working with the debugger