fix: Collapse items semantic props by zombieJ · Pull Request #56517 · ant-design/ant-design

zombieJ · 2026-01-06T16:00:50Z

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

The specific problem to be addressed.

List the final API implementation and usage if needed.

If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Read Keep a Changelog! Track your changes, like a cat tracks a laser pointer.

Describe the impact of the changes on developers, not the solution approach.

Reference: https://ant.design/changelog

Language	Changelog
🇺🇸 English	Fix Collapse `items` semantic structure props not working.
🇨🇳 Chinese	修复 Collapse `items` 语义化属性无效的问题。

bolt-new-by-stackblitz · 2026-01-06T16:00:54Z

Run & review this pull request in StackBlitz Codeflow.

gemini-code-assist · 2026-01-06T16:01:03Z

Summary of Changes

Hello @zombieJ, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug within the Collapse component where its items were not correctly interpreting semantic properties. The fix is achieved by upgrading the @rc-component/collapse library to version ~1.2.0, which includes the necessary corrections to restore proper functionality.

Highlights

Dependency Update: Updated the @rc-component/collapse dependency from ~1.1.2 to ~1.2.0. This update is crucial for resolving an issue where semantic properties for Collapse items were not functioning correctly.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2026-01-06T16:01:05Z

Visual Regression Build for PR # Failed ❌

Potential causes:

upstream workflow status: success upstream job link
current workflow summary:
- download report artifact status: skipped
- report upload status: skipped
- workflow url: https://github.com/ant-design/ant-design/actions/runs/20754296779

github-actions · 2026-01-06T16:01:05Z

coderabbitai · 2026-01-06T16:01:06Z

📝 Walkthrough

Summary by CodeRabbit

发布说明

Chores
- 更新了折叠组件库的依赖版本，以获取最新的改进和优化。

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

更新 @rc-component/collapse 依赖版本从 ~1.1.2 升级至 ~1.2.0，以修复 Collapse Panel 的样式和类名属性无法生效的问题。

Changes

组件 / 文件	变更摘要
依赖版本更新 `package.json`	将 `@rc-component/collapse` 版本从 `~1.1.2` 更新为 `~1.2.0`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

小兔跳跃欢欣鼓舞，🐰
collapse 版本轻轻升级，
styles 和 className 重获新生，
Panel 面板焕然一新！✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: Collapse items semantic props' clearly summarizes the main change - updating the collapse component to fix semantic structure properties, which directly aligns with the changeset of updating @rc-component/collapse dependency and the linked issue #55916 about Panel styles and className not working.
Description check	✅ Passed	The PR description is related to the changeset and linked issues. It references issue #55916 about Collapse items semantic props not working, includes proper changelog entries, and follows the repository's PR template checklist.
Linked Issues check	✅ Passed	The PR addresses issue #55916 by updating @rc-component/collapse to version ~1.2.0, which includes the fix for Panel style and className props not taking effect. The dependency update aligns with the coding objectives to resolve the semantic structure props issue.
Out of Scope Changes check	✅ Passed	All changes in the PR are directly related to the linked issue #55916. The single modification updates @rc-component/collapse dependency to include the upstream fix for semantic structure props, with no extraneous changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix-collapse

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae9fc64 and 871c625.

📒 Files selected for processing (1)

package.json

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-11-13T02:52:08.942Z

Learnt from: meet-student
Repo: ant-design/ant-design PR: 55697
File: components/drawer/index.tsx:86-88
Timestamp: 2025-11-13T02:52:08.942Z
Learning: In Ant Design components (components/**/*.{ts,tsx}), always use `import useId from 'rc-util/lib/hooks/useId'` instead of `React.useId()` for generating unique IDs, to ensure compatibility with React 16-19. The rc-util hook automatically uses the native implementation in React 18+ and provides a fallback for older versions.

Applied to files:

package.json

📚 Learning: 2026-01-04T15:16:45.886Z

Learnt from: CR
Repo: ant-design/ant-design PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-04T15:16:45.886Z
Learning: Support React 18 ~ 19 versions and Chrome 80+ browser compatibility

Applied to files:

package.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)

GitHub Check: test lib/es module (es, 2/2)
GitHub Check: test lib/es module (lib, 2/2)
GitHub Check: test lib/es module (es, 1/2)
GitHub Check: test-react-latest (dom, 2/2)
GitHub Check: test lib/es module (lib, 1/2)
GitHub Check: test-react-legacy (18, 2/2)
GitHub Check: test-react-latest (dom, 1/2)
GitHub Check: test-react-legacy (18, 1/2)
GitHub Check: lint
GitHub Check: build
GitHub Check: test-node
GitHub Check: visual-diff snapshot (1/2)
GitHub Check: visual-diff snapshot (2/2)
GitHub Check: build preview
GitHub Check: size
GitHub Check: build
GitHub Check: Analyze (javascript)
GitHub Check: Cloudflare Pages: ant-design-next
GitHub Check: build

🔇 Additional comments (1)

package.json (1)

120-120: 依赖版本升级验证通过。

@rc-component/collapse 从 ~1.1.2 升级到 ~1.2.0（2026年1月6日发布）包含了修复 Panel style 和 className 属性的补丁，完全符合 PR 目标。该版本声明支持 React ≥18.0.0，与项目的 React 18-19 支持策略兼容。无安全漏洞。

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

socket-security · 2026-01-06T16:01:39Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	cli-progress@3.12.0
	cross-env@10.1.0

View full report

gemini-code-assist

Code Review

This pull request fixes a bug where semantic props for Collapse items were not working correctly by updating the @rc-component/collapse dependency to version ~1.2.0. The change is straightforward and directly targets the root cause in the dependency. I've added a comment suggesting the addition of a regression test to prevent this issue from recurring in the future.

package.json

pkg-pr-new · 2026-01-06T16:04:27Z

More templates

npm i https://pkg.pr.new/ant-design/ant-design/antd@56517

commit: 871c625

github-actions · 2026-01-06T16:04:59Z

size-limit report 📦

Path	Size
`dist/antd.min.js`	522.91 KB (+106 B 🔺)
`dist/antd-with-locales.min.js`	616.77 KB (+385 B 🔺)

cloudflare-workers-and-pages · 2026-01-06T16:07:08Z

Deploying ant-design-next with Cloudflare Pages

Latest commit:	`871c625`
Status:	✅ Deploy successful!
Preview URL:	https://6238ffce.ant-design-next.pages.dev
Branch Preview URL:	https://fix-collapse.ant-design-next.pages.dev

View logs

cloudflare-workers-and-pages · 2026-01-06T16:07:27Z

Deploying ant-design with Cloudflare Pages

Latest commit:	`871c625`
Status:	✅ Deploy successful!
Preview URL:	https://925a0d79.ant-design.pages.dev
Branch Preview URL:	https://fix-collapse.ant-design.pages.dev

View logs

codecov · 2026-01-06T16:13:35Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ae9fc64) to head (871c625).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master    #56517   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          805       805           
  Lines        14844     14844           
  Branches      3920      3920           
=========================================
  Hits         14844     14844

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov · 2026-01-06T17:20:27Z

Bundle Report

Changes will decrease total bundle size by 8.13MB (-67.79%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
antd.min-array-push	3.86MB	-8.13MB (-67.79%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antd.min-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`antd-with-locales.min.js` (New)	2.12MB	2.12MB	100.0% 🚀
`antd.min.js` (New)	1.74MB	1.74MB	100.0% 🚀
~~`antd-with-locales.js`~~ (Deleted)	-6.3MB	0 bytes	-100.0% 🗑️
~~`antd.js`~~ (Deleted)	-5.69MB	0 bytes	-100.0% 🗑️

fix: Collapse items semantic props

871c625

gemini-code-assist bot reviewed Jan 6, 2026

View reviewed changes

package.json Show resolved Hide resolved

li-jia-nan approved these changes Jan 7, 2026

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 7, 2026

meet-student approved these changes Jan 7, 2026

View reviewed changes

meet-student merged commit 1463722 into master Jan 7, 2026
49 of 50 checks passed

meet-student deleted the fix-collapse branch January 7, 2026 01:14

meet-student mentioned this pull request Jan 7, 2026

Collapse 折叠面板 ItemType styles classNames 不生效 #56519

Closed

zombieJ mentioned this pull request Jan 13, 2026

docs: Changelog of 6.2.0 #56588

Merged

17 tasks

Uh oh!

Conversation

zombieJ commented Jan 6, 2026

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Uh oh!

bolt-new-by-stackblitz bot commented Jan 6, 2026

Uh oh!

gemini-code-assist bot commented Jan 6, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression Build for PR # Failed ❌

Uh oh!

github-actions bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

发布说明

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

socket-security bot commented Jan 6, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

pkg-pr-new bot commented Jan 6, 2026

Uh oh!

github-actions bot commented Jan 6, 2026

size-limit report 📦

Uh oh!

cloudflare-workers-and-pages bot commented Jan 6, 2026

Deploying ant-design-next with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented Jan 6, 2026

Deploying ant-design with Cloudflare Pages

Uh oh!

codecov bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Jan 6, 2026

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 6, 2026 •

edited

Loading

github-actions bot commented Jan 6, 2026 •

edited

Loading

coderabbitai bot commented Jan 6, 2026 •

edited

Loading

codecov bot commented Jan 6, 2026 •

edited

Loading