Skip to content

Update DatePicker docs#15092

Merged
afc163 merged 1 commit intoant-design:masterfrom
ztplz:rangepicker
Mar 16, 2019
Merged

Update DatePicker docs#15092
afc163 merged 1 commit intoant-design:masterfrom
ztplz:rangepicker

Conversation

@ztplz
Copy link
Contributor

@ztplz ztplz commented Feb 27, 2019 •
edited by issuehunt-oss bot
Loading

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
    DatePicker.Range not working if start date is null #14761
    RangePicker missing from value will cause app crashed if clicking on the component #13433
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

@ztplz
Copy link
Contributor Author

ztplz commented Feb 27, 2019

Land after react-component/calendar#520

afc163
afc163 reviewed Feb 27, 2019
View reviewed changes
components/date-picker/index.zh-CN.md Outdated
Copy link
Member

@afc163 afc163 Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

支持 undefined 么？

Copy link
Contributor Author

@ztplz ztplz Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不支持，我按null判断的，undefined需要支持吗

Copy link
Member

@afc163 afc163 Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined 更合理一点，语义上是开始/结束日期未指定。

@netlify
Copy link

netlify bot commented Feb 27, 2019 •
edited
Loading

Deploy preview for ant-design ready!

Built with commit 07c9369

https://deploy-preview-15092--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #15092 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15092      +/-   ##
==========================================
- Coverage   92.82%   92.77%   -0.05%     
==========================================
  Files         236      236              
  Lines        6260     6260              
  Branches     1875     1841      -34     
==========================================
- Hits         5811     5808       -3     
- Misses        446      451       +5     
+ Partials        3        1       -2
Impacted Files Coverage Δ
components/_util/wave.tsx 84.61% <0%> (-2.89%) ⬇️
components/transfer/index.tsx 85.43% <0%> (ø) ⬆️
components/time-picker/index.tsx 82.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2826f16...68d91b1. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 27, 2019 •
edited
Loading

Codecov Report

Merging #15092 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15092   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files         250      250           
  Lines        6653     6653           
  Branches     1948     1934   -14     
=======================================
  Hits         6271     6271           
  Misses        381      381           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb7d6c...07c9369. Read the comment docs.

afc163
afc163 reviewed Feb 27, 2019
View reviewed changes
components/date-picker/index.en-US.md Outdated
Copy link
Member

@afc163 afc163 Feb 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null undefined 加 `

@afc163
Copy link
Member

afc163 commented Mar 15, 2019

ping~

@afc163
Copy link
Member

afc163 commented Mar 15, 2019

diff 有点奇怪

@ztplz
Copy link
Contributor Author

ztplz commented Mar 15, 2019

我这个merge不知道merge了什么东西

@afc163 afc163 merged commit b40c0d3 into ant-design:master Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afc163 afc163 afc163 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ztplz @afc163