Skip to content

feat: refactor source class#690

Merged
pluAtAnsys merged 137 commits intomainfrom
refactor/source
Mar 2, 2026
Merged

feat: refactor source class#690
pluAtAnsys merged 137 commits intomainfrom
refactor/source

Conversation

@pluAtAnsys
Copy link
Collaborator

@pluAtAnsys pluAtAnsys commented Aug 5, 2025 •
edited
Loading

Description

  • radiant flux
  • luminous flux
  • luminous_intensity
    need some testing and proper definition

Add properties to SourceLuminaire:

  • radiant flux
  • luminous flux
  • intensity file
  • axissystem

add properties to SourceRayfile:

  • rayfile_url
  • radiant flux
  • luminous flux
  • axissystem

add properties to SourceSurface

  • add properties to exitance class
    • XMP file URL
    • axissystem
  • radiant flux
  • luminous flux
  • luminous_intensity
  • Constant exitance class + Geometry property

Issue linked

Refactor source #684
Refactor Intensity with peroperties #678
Refactor SPectrum #683

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@pluAtAnsys pluAtAnsys linked an issue Aug 5, 2025 that may be closed by this pull request
Refactor source #684
Closed
@pluAtAnsys pluAtAnsys self-assigned this Aug 5, 2025
@pluAtAnsys pluAtAnsys removed a link to an issue Aug 5, 2025
Refactor source #684
Closed
This was linked to issues Aug 5, 2025
Refactor sensor #685
Closed
Refactor source #684
Closed
Refactor SPectrum #683
Closed
@pluAtAnsys pluAtAnsys changed the title wip: refactor source class feat: refactor source class Aug 6, 2025
@pluAtAnsys pluAtAnsys removed a link to an issue Aug 6, 2025
Refactor sensor #685
Closed
@codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.25287% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.57%. Comparing base (795f810) to head (31fd07d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/speos/core/intensity.py 84.82% 17 Missing ⚠️
src/ansys/speos/core/spectrum.py 92.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
- Coverage   86.86%   86.57%   -0.30%     
==========================================
  Files          44       44              
  Lines        7141     7767     +626     
==========================================
+ Hits         6203     6724     +521     
- Misses        938     1043     +105

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pluAtAnsys and others added 19 commits February 24, 2026 12:34
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
2064dab 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
555a0d1 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
8c3c148 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
42d3006 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
a227d4b 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
4b8709e 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
d7247dd 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
9a595c7 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
c3a9faf 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
392babd 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
Merge remote-tracking branch 'origin/refactor/source' into refactor/s…
b2c6188 
…ource
docstring update
991a22c
docstring update
a47206a
docstring update
3c9b5fe
@pluAtAnsys @echambla
Update src/ansys/speos/core/source.py
34e8571 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pre-commit-ci
ci: auto fixes from pre-commit.com hooks.
bb1f11f 
for more information, see https://pre-commit.ci
@pluAtAnsys @echambla
Update src/ansys/speos/core/project.py
ccd6b7d 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
@pluAtAnsys @echambla
Update src/ansys/speos/core/project.py
10f48ad 
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
docstring update
0ddb24b
@pluAtAnsys pluAtAnsys requested a review from echambla February 24, 2026 13:58
StefanThoene
StefanThoene previously approved these changes Feb 25, 2026
View reviewed changes
@pluAtAnsys pluAtAnsys merged commit e3fcc2e into main Mar 2, 2026
25 checks passed
@pluAtAnsys pluAtAnsys deleted the refactor/source branch March 2, 2026 10:21
@SMoraisAnsys SMoraisAnsys mentioned this pull request Mar 10, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys left review comments

@echambla echambla echambla approved these changes

@StefanThoene StefanThoene StefanThoene left review comments

@jomadec jomadec Awaiting requested review from jomadec jomadec is a code owner

Assignees

@pluAtAnsys pluAtAnsys

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor source Refactor SPectrum Refactor Intensity with peroperties

6 participants

@pluAtAnsys @StefanThoene @echambla @Revathyvenugopal162 @SMoraisAnsys @pyansys-ci-bot