Update k8s_exec and k8s_cp to include container name#1858
Update k8s_exec and k8s_cp to include container name#1858rooftopcellist merged 1 commit intoansible:develfrom
Conversation
|
Good point, thanks for the PR @fluzzykitten ! I checked that the container name is indeed correct: However, I expect you will also need to specify the container here as well right @fluzzykitten ?
Actually, pretty much all of these places: |
|
While looking at this PR, I noticed this typo: |
We need to specify a container in environments that use sidecar injection, like in the case of istio service mesh. If the container is not specified, and a side car is injected so there are multiple containers running in the pod, this task will fail because a container was not specified in a pod with multiple containers.
|
@rooftopcellist Shoot! You're right, I only pushed one of the files. My bad. MR updated with the other instances of the |
|
@fluzzykitten thanks for the quick update! I just tested out a backup and restore and didn't run into any issues. Thanks for the contribution! |
SUMMARY
We need to specify a container in environments that use sidecar injection, like in the case of istio service mesh. If the container is not specified, and a side car is injected so there are multiple containers running in the pod, this task will fail because a container was not specified in a pod with multiple containers.
ISSUE TYPE
Bug preventing backups in environments that use Istio service mesh or other automatic side-car injection
ADDITIONAL INFORMATION
Container that we create is the same name as the pod, so we just need to tell the backup to use the container we created, to differentiate it from any sidecars containers that might've been injected