Create _metrics_utility_secret for metrics utility#1857
Merged
rooftopcellist merged 1 commit intoansible:develfrom May 16, 2024
Merged
Create _metrics_utility_secret for metrics utility#1857rooftopcellist merged 1 commit intoansible:develfrom
rooftopcellist merged 1 commit intoansible:develfrom
Conversation
rooftopcellist
approved these changes
May 16, 2024
rooftopcellist
approved these changes
May 16, 2024
Member
rooftopcellist
left a comment
There was a problem hiding this comment.
Without this, the _metrics_utility_secret param would not be set from metrics_utility_secret.
It will fail if the metrics_utility_secret or default name for that secret does not exist. We could potentially add a preflight check for that in a follow-up PR. But not required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The template for the metrics utility cronjobs references the variable _metrics_utility_secret. This variable is missing from the list of variables constructed for the utility.
ISSUE TYPE