Skip to content

installer: nginx: add missing locales location required by ui_next#1822

Merged
rooftopcellist merged 1 commit intoansible:develfrom
sinuscosinustan:ts-fix-locales
May 1, 2024
Merged

installer: nginx: add missing locales location required by ui_next#1822
rooftopcellist merged 1 commit intoansible:develfrom
sinuscosinustan:ts-fix-locales

Conversation

@sinuscosinustan
Copy link
Copy Markdown
Contributor

@sinuscosinustan sinuscosinustan commented Apr 12, 2024

SUMMARY

The new UI depends on the locales available via ingress/locales which is being served as static file and not via Django.

A change in the nginx.conf was already done for the dev environment in commit ec4f10d86881389af12371f90cb75af03417d109 (AWX), but not here.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change

@sinuscosinustan sinuscosinustan changed the title installer: nginx: add missing locales location for ui_next installer: nginx: add missing locales location required by ui_next Apr 12, 2024
The new UI depends on the locales available via ingress/locales which
is being served as static file and not via Django.

A change in the nginx.conf was already done for the dev environment
in commit ec4f10d86881389af12371f90cb75af03417d109 (AWX), but not
here.

Signed-off-by: Tom Siewert <tom.siewert@hetzner.com>
@sinuscosinustan
Copy link
Copy Markdown
Contributor Author

@rooftopcellist PR Check failed with The PR body must contain exactly one of [ 'Bug, Docs Fix or other nominal change', 'New or Enhanced Feature', 'Breaking Change' ], but it contains a Bug fix in the body. Any idea why it fails?

@rooftopcellist
Copy link
Copy Markdown
Member

rooftopcellist commented May 1, 2024

@tomsiewert Thanks for the PR! Yes, CI was complaining because it expects 3 categories, the entire category is Bug, Docs Fix or other nominal change, not just Bug Fix. This is part of our automation for generating release notes. Admittedly, this can be a bit cumbersome. Sorry for the confusion!

I edited the description, it should pass now, I'll merge shortly.

@rooftopcellist rooftopcellist merged commit 6fff7cb into ansible:devel May 1, 2024
@sinuscosinustan sinuscosinustan deleted the ts-fix-locales branch May 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants