Skip to content

Fix "external_hostname" should not be required while using Route ingress#1807

Merged
TheRealHaoLiu merged 1 commit intoansible:develfrom
TheRealHaoLiu:fix-mesh-ingress-ocp
Apr 3, 2024
Merged

Fix "external_hostname" should not be required while using Route ingress#1807
TheRealHaoLiu merged 1 commit intoansible:develfrom
TheRealHaoLiu:fix-mesh-ingress-ocp

Conversation

@TheRealHaoLiu
Copy link
Copy Markdown
Member

SUMMARY

Fix "external_hostname" should not be required while using Route ingress

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
ADDITIONAL INFORMATION

@fosterseth
Copy link
Copy Markdown
Member

we have a task that sets the external_hostname if ingress_type is "route"

- name: Set external_hostname
  set_fact:
    external_hostname: "{{ ingress.result.status.ingress[0].host }}"
  when: ingress_type | lower == 'route'

and in the jinja2 template it is only referenced under a {% if ingress_type|lower == "route" %} conditional

so not sure in which situation this wouldn't be defined when referenced.

@TheRealHaoLiu TheRealHaoLiu enabled auto-merge (squash) April 3, 2024 15:58
@TheRealHaoLiu
Copy link
Copy Markdown
Member Author

we have a task that sets the external_hostname if ingress_type is "route"

- name: Set external_hostname
  set_fact:
    external_hostname: "{{ ingress.result.status.ingress[0].host }}"
  when: ingress_type | lower == 'route'

and in the jinja2 template it is only referenced under a {% if ingress_type|lower == "route" %} conditional

so not sure in which situation this wouldn't be defined when referenced.

the task execute after the route is created

so bug affect all case when ingress_type=route

@fosterseth
Copy link
Copy Markdown
Member

ah didn't realize the ordering there, got it

@TheRealHaoLiu TheRealHaoLiu merged commit fcbf394 into ansible:devel Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants