Fix "external_hostname" should not be required while using Route ingress#1807
Merged
TheRealHaoLiu merged 1 commit intoansible:develfrom Apr 3, 2024
Merged
Conversation
Member
|
we have a task that sets the - name: Set external_hostname
set_fact:
external_hostname: "{{ ingress.result.status.ingress[0].host }}"
when: ingress_type | lower == 'route'and in the jinja2 template it is only referenced under a so not sure in which situation this wouldn't be defined when referenced. |
fosterseth
approved these changes
Apr 3, 2024
Member
Author
the task execute after the route is created so bug affect all case when ingress_type=route |
Member
|
ah didn't realize the ordering there, got it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix "external_hostname" should not be required while using Route ingress
ISSUE TYPE
ADDITIONAL INFORMATION