postgresql: Cast sorted_old_postgres_pods as list#1791
Merged
rooftopcellist merged 1 commit intoansible:develfrom Mar 27, 2024
Merged
postgresql: Cast sorted_old_postgres_pods as list#1791rooftopcellist merged 1 commit intoansible:develfrom
rooftopcellist merged 1 commit intoansible:develfrom
Conversation
With ansible 2.9.27 (operator-sdk v1.27.0) then the reverse filter returns an iterator so we need to cast it to list. The behavior doesn't exist when using a more recent operator-sdk version like v1.34.0 (ansible-core 2.15.8) but using the list filter on that version works too (even if not needed) "sorted_old_postgres_pods": "<list_reverseiterator object at 0x7f539eaa5610>" Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
c23cde7 to
66f23d3
Compare
rooftopcellist
approved these changes
Mar 27, 2024
Member
|
Thanks for adding the backwards compatibility. We will likely need to be backwards compatible with the earlier ansible-operator-sdk image for the next 6-12 months. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
With ansible 2.9.27 (operator-sdk v1.27.0) then the reverse filter returns an iterator so we need to cast it to list. The behavior doesn't exist when using a more recent operator-sdk version like v1.34.0 (ansible-core 2.15.8) but using the list filter on that version works too (even if not needed)
ISSUE TYPE
ADDITIONAL INFORMATION