docs: add description of init container image definition#1779
Merged
rooftopcellist merged 3 commits intoansible:develfrom Mar 27, 2024
Merged
docs: add description of init container image definition#1779rooftopcellist merged 3 commits intoansible:develfrom
rooftopcellist merged 3 commits intoansible:develfrom
Conversation
kurokobo
reviewed
Mar 19, 2024
Contributor
kurokobo
left a comment
There was a problem hiding this comment.
@zaki-lknr
Hi, thanks for sending helpful PR to improve docs! 😃
I've leave some minor comments, could you please check if you would like?
docs/user-guide/advanced-configuration/deploying-a-specific-version-of-awx.md
Show resolved
Hide resolved
docs/user-guide/advanced-configuration/deploying-a-specific-version-of-awx.md
Outdated
Show resolved
Hide resolved
…rsion-of-awx.md Co-authored-by: kurokobo <kuro664@gmail.com>
…rsion-of-awx.md Co-authored-by: kurokobo <kuro664@gmail.com>
kurokobo
approved these changes
Mar 20, 2024
rooftopcellist
approved these changes
Mar 27, 2024
Member
rooftopcellist
left a comment
There was a problem hiding this comment.
@zaki-lknr Thanks for adding this improvement to the docs!
I think it might be useful to (in a follow-up PR) add a sample AWX custom resource yaml file for disconnected environment, like what we did here for resource requests and limits configuration, etc. Then link to it from these docs so that folks can copy, paste and fill out their specific internal registry urls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add
init_container_imageparameter.This parameter is not dependent of
ee_imagessettings. Therefore, use it when we want to pull a custom image or from private cotainer registry (e.g. disconnected internet).ISSUE TYPE
ADDITIONAL INFORMATION