add support for defining loadbalancer class#1746
Merged
fosterseth merged 1 commit intoansible:develfrom Mar 6, 2024
Merged
Conversation
| x-descriptors: | ||
| - urn:alm:descriptor:com.tectonic.ui:advanced | ||
| - urn:alm:descriptor:com.tectonic.ui:string | ||
| - urn:alm:descriptor:com.tectonic.ui:fieldDependency:service_type:LoadBalancer |
Member
There was a problem hiding this comment.
This is how it currently displays. Looks good!
rooftopcellist
approved these changes
Mar 6, 2024
Member
rooftopcellist
left a comment
There was a problem hiding this comment.
It would be nice to expand upon the docs for this in a future PR. But this looks good, thanks!
fosterseth
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds support to define the load balancer class in Kubernetes clusters that may have multiple load balancer controllers or if a load balancer controller supports multiple classes.
ISSUE TYPE
ADDITIONAL INFORMATION
This allows the
spec.loadBalancerClassfield to be specified in the operator-created service for AWX.