Bind EE images version with DEFAULT_AWX_VERSION#1740
Bind EE images version with DEFAULT_AWX_VERSION#1740TheRealHaoLiu merged 4 commits intoansible:develfrom
Conversation
|
@bartowl thanks for this PR! will pull down and test it out soon |
|
https://github.com/ansible/awx/blob/devel/.github/workflows/stage.yml#L109-L115 https://github.com/ansible/awx-operator/blob/devel/Dockerfile#L9C1-L12C41 https://github.com/ansible/awx-operator/blob/devel/roles/installer/defaults/main.yml#L256 and this PR takes that and uses it, that looks correct |
TheRealHaoLiu
left a comment
There was a problem hiding this comment.
https://github.com/ansible/awx-operator/blob/devel/roles/mesh_ingress/defaults/main.yml#L12
one missing place to fix
b2ca222 to
ef6c0a5
Compare
|
now that i committed to this PR i shouldn't be the approver anymore 🤣 @fosterseth double check my work plz |
|
test process
result
... and hit a bug that i created somewhere else...regret my decision to try to do something at 5PM...
|
|
and realize that i should probably do a upgrade test... than deploy awx while waiting for my grill to come up to temp verify that we don't create duplicate default ee in awx...(we probably shouldn't) |
|
@shanemcd what do you think about this behavioral change? |
8f2f5c8 to
d120055
Compare
|
this issue to the matrix for the community to vote on the behavior please thumbs up the suggested change for the desire behavior that you want |
e8c516b to
f008210
Compare


SUMMARY
This PR fixes #1484 by binding following images to
DEFAULT_AWX_VERSIONinstead of currentlatesttag:ee_images- default execution environment (will add new EE with each upgrade, leaving previous as-is)control_plane_ee_image- will switch it to new version with each updateinit_container_image- will be also switched to new version with each updateISSUE TYPE
ADDITIONAL INFORMATION
Currently those were linked with
latestversion of images which might resulted in unexpected effects for ee_image once thelatesttag was updated.For
control_plane_ee_imageandinit_container_image- they were not changed until container re-create, but should this happen they would also be updated (possibly unaware/unexpected)In order to prevent switching to updated image versions on upgrade it is possible to define
control_plane_ee_imageand (AFAIK undocumented)init_container_image/init_container_image_versionin AWX resource spec.New EE image will always be added upon upgrade, but it will be clearly marked with AWX version.
Additionally it also makes small fix for 'or' in check of
init_container_image_versionpresence which could leave to errors when init_container_image_version would not be specified andinit_container_imagebe defined (separate commit)